Merge lp://staging/~nskaggs/reminders-app/cmake-build-test into lp://staging/reminders-app

Proposed by Nicholas Skaggs
Status: Rejected
Rejected by: Nicholas Skaggs
Proposed branch: lp://staging/~nskaggs/reminders-app/cmake-build-test
Merge into: lp://staging/reminders-app
Diff against target: 184 lines (+44/-36)
5 files modified
CMakeLists.txt (+24/-23)
click/CMakeLists.txt (+8/-0)
click/manifest.json.in (+7/-7)
src/app/main.cpp (+4/-2)
tests/autopilot/reminders/tests/__init__.py (+1/-4)
To merge this branch: bzr merge lp://staging/~nskaggs/reminders-app/cmake-build-test
Reviewer Review Type Date Requested Status
Nicholas Skaggs (community) Disapprove
Leo Arias (community) Approve
Review via email: mp+216793@code.staging.launchpad.net

Description of the change

DO NOT MERGE, TESTING ONLY

To post a comment you must log in.
108. By Nicholas Skaggs

undo changes unintentional to manifest; use new framework

Revision history for this message
Leo Arias (elopio) wrote :

183 + 'com.ubuntu.reminders',

If you change this ^, you will need to change the launch statement in the tests/autopilot/reminders/tests/__init__.py file.

review: Needs Fixing
Revision history for this message
Leo Arias (elopio) wrote :

Scratch that, I'm drunk.

Revision history for this message
Leo Arias (elopio) wrote :

Approve, as the click you sent me works. I'm not able to test it myself though.

review: Approve
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

I might tweak this to allow qtcreator to build properly to and pursuing merging.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

dpm got to this first :-)

review: Disapprove

Unmerged revisions

108. By Nicholas Skaggs

undo changes unintentional to manifest; use new framework

107. By Nicholas Skaggs

remove unused -q arg for installed launch

106. By Nicholas Skaggs

fix launch name

105. By Nicholas Skaggs

restore working click build

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches