Merge lp://staging/~nskaggs/juju-release-tools/make-pr-tarball into lp://staging/juju-release-tools

Proposed by Nicholas Skaggs
Status: Merged
Merged at revision: 337
Proposed branch: lp://staging/~nskaggs/juju-release-tools/make-pr-tarball
Merge into: lp://staging/juju-release-tools
Diff against target: 229 lines (+131/-63)
4 files modified
build-juju-source.bash (+56/-0)
check-source-depends.bash (+16/-0)
make-pr-tarball.bash (+53/-0)
make-release-tarball.bash (+6/-63)
To merge this branch: bzr merge lp://staging/~nskaggs/juju-release-tools/make-pr-tarball
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+305370@code.staging.launchpad.net

Description of the change

This adds a new script that tweaks make-release-tarball slightly. I'd like to just expand the current script, but as you'll note by diffing the two this one has a one line difference in where the location of the tarball is adding an additional difference beyond the checkout.

It would be useful to migrate away from needing those 4 args in make-release-tarball and to use this logic instead. However, but I'm not sure what will happen longer term. For now, leaving this PR for comment. This is installed currently and in use as-is for the developer workflow experiments. I don't anticipate merging anything until we've solidified those experiments.

To post a comment you must log in.
337. By Nicholas Skaggs

Fix path

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

This is the final version.

338. By Nicholas Skaggs

Add breakouts and common script points; add echos to original script

Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you. I have some comments and suggestions inline. Can we get this merged quickly so that we get a day runs with these changes in place before the release.

review: Approve (code)
339. By Nicholas Skaggs

use source instead of .

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches