Merge lp://staging/~nskaggs/juju-release-tools/add-snap-script into lp://staging/juju-release-tools

Proposed by Nicholas Skaggs
Status: Needs review
Proposed branch: lp://staging/~nskaggs/juju-release-tools/add-snap-script
Merge into: lp://staging/juju-release-tools
Diff against target: 94 lines (+90/-0)
1 file modified
lp-build-juju-snap.py (+90/-0)
To merge this branch: bzr merge lp://staging/~nskaggs/juju-release-tools/add-snap-script
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Needs Information
Review via email: mp+303055@code.staging.launchpad.net

Description of the change

Add snap creation script for edge channel.

This script requests builds for https://launchpad.net/~jujuisquality/+snap/juju. It's installed on ci-master in the jenkins user crontab. It runs daily at 1700 UTC.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

I have some concerns inline.

review: Needs Information (code)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Replied with my own set of questions. In general if you want more time invested in cleaning this up, I'll do it. It's mostly just an edited clone of lp:ubuntu-core-snap; warts and all.

Unmerged revisions

331. By Nicholas Skaggs

Add snap build request script

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches