DockManager

Merge lp://staging/~nowymarluk/dockmanager/skype_helper into lp://staging/dockmanager

  1. skype_helper
  2. Merge into trunk
Proposed by Lukasz Marcinowski
Status: Merged
Merged at revision: 38
Proposed branch: lp://staging/~nowymarluk/dockmanager/skype_helper
Merge into: lp://staging/dockmanager
Diff against target: 330 lines (+275/-2)
5 files modified
data/Makefile.am (+8/-2)
metadata/Makefile.am (+1/-0)
metadata/skype_control.py.info (+5/-0)
scripts/Makefile.am (+1/-0)
scripts/skype_control.py (+260/-0)
To merge this branch: bzr merge lp://staging/~nowymarluk/dockmanager/skype_helper
Reviewer Review Type Date Requested Status
Rico Tzschichholz Approve
Lukasz Marcinowski (community) Needs Resubmitting
Robert Dyer (community) Needs Fixing
Danielle Foré Pending
Review via email: mp+26715@code.staging.launchpad.net

Description of the change

Helper for Skype

It use Skype API and DBus.

It shows status by changing icon in docky. You can set status by right-menu. It shows unread message/missed calls number in badge.

To post a comment you must log in.
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Your merge should only add your helper files and shouldnt conflict with current files!
Please clean up your merge.

review: Needs Fixing
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

You need to "bzr branch lp:dockmanager", add your files to it and then push it to your branch.

Revision history for this message
Robert Dyer (psybers) wrote :

Also please rename any occurrence of 'Docky' to 'DockManager'.

review: Needs Fixing
Revision history for this message
Lukasz Marcinowski (nowymarluk) wrote :

I have done what you wrote. Now there is no conflict

review: Needs Resubmitting
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Makefile.am is missing a "\".
Your .info file is no longer correct syntax. Please merge lp:dockmanager and take a look at the new files.

review: Needs Fixing
Revision history for this message
Lukasz Marcinowski (nowymarluk) wrote :

> Makefile.am is missing a "\".

I don't see it. Which one?

> Your .info file is no longer correct syntax. Please merge lp:dockmanager and
> take a look at the new files.

Ok this is done.

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Please use:
AppName=skype

review: Needs Fixing
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

I would be great if you get some better quality status icons with a size of 128px or SVGs

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

I am sorry, but your icons aren't so well yet. I hope you can them better matching the original ones. This could help you: http://www.jiinx.net/news/wp-content/uploads/2009/08/SkypeBlue_512x512.png

review: Needs Fixing
lp://staging/~nowymarluk/dockmanager/skype_helper updated
42. By Lukasz Marcinowski

icons are now more similar to the orginal ones (from windows version of Skype)

Revision history for this message
Lukasz Marcinowski (nowymarluk) wrote :

Icons right now are more similar to original ones, but they are not the same as in Linux version of Skype. I prefer icons provided by the Windows version of Skype (Colors are better for recognizability of the user status).

lp://staging/~nowymarluk/dockmanager/skype_helper updated
43. By Lukasz Marcinowski

small fix with offline status

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

I have pushed your skype helper with quite some changes and new icons made by DanRabbit

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: