Merge lp://staging/~nottrobin/charms/trusty/apache2/relation-servername into lp://staging/charms/trusty/apache2
Proposed by
Robin Winslow
| Status: | Merged |
|---|---|
| Merged at revision: | 60 |
| Proposed branch: | lp://staging/~nottrobin/charms/trusty/apache2/relation-servername |
| Merge into: | lp://staging/charms/trusty/apache2 |
| Diff against target: |
18 lines (+6/-2) 1 file modified
hooks/hooks.py (+6/-2) |
| To merge this branch: | bzr merge lp://staging/~nottrobin/charms/trusty/apache2/relation-servername |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Marco Ceppi (community) | Approve | ||
| Review Queue (community) | automated testing | Needs Fixing | |
|
Review via email:
|
|||
Description of the change
For the assets manager project mojo spec (lp:~canonical-is/canonical-mojo-specs/mojo-comms-assets) we need access to the `servername` setting when the `website` relation is created.
I thought this would be a generally useful feature, and certainly wouldn't do any harm as it can just be ignored by charsm that don't want to use it, so I thought it'd be better to submit this MP rather than create a permanent fork of the apache2 charm.
To post a comment you must log in.
Revision history for this message
| Review Queue (review-queue) wrote | # |
review:
Needs Fixing
(automated testing)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This items has failed automated testing! Results available here http://