Merge lp://staging/~nosklo/infobat/modechanged_fix into lp://staging/infobat
Proposed by
Clóvis Fabrício
| Status: | Merged |
|---|---|
| Merge reported by: | Aaron Gallagher |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~nosklo/infobat/modechanged_fix |
| Merge into: | lp://staging/infobat |
| Diff against target: |
60 lines (+16/-34) 1 file modified
infobat/irc.py (+16/-34) |
| To merge this branch: | bzr merge lp://staging/~nosklo/infobat/modechanged_fix |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Aaron Gallagher | Approve | ||
|
Review via email:
|
|||
Commit message
fixed Infobat.modeChanged to deal with twisted changes on twisted changeset 27721.
Removes Infobat.irc_MODE and fixes Infobat.modeChanged to deal with new way parameters are passed by the default IRCClient.irc_MODE, since they're now sane after this changeset:
Description of the change
Twisted's sucky IRCClient.irc_MODE was fixed in changeset 27721 as below:
http://
This branch implements the needed changes to make it work with the new code, by removing our reimplementation on Infobat.irc_MODE and making Infobat.modeChanged deal with the new parameter data structure it receives.
To post a comment you must log in.
Revision history for this message
| Aaron Gallagher (habnabit) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
