Ubuntu
xfce4-xkb-plugin package

Merge lp://staging/~noskcaj/ubuntu/trusty/xfce4-xkb-plugin/lp-733563 into lp://staging/ubuntu/trusty/xfce4-xkb-plugin

  1. Trusty (14.04)
  2. lp-733563
  3. Merge into trusty
Proposed by Jackson Doak
Status: Work in progress
Proposed branch: lp://staging/~noskcaj/ubuntu/trusty/xfce4-xkb-plugin/lp-733563
Merge into: lp://staging/ubuntu/trusty/xfce4-xkb-plugin
Diff against target: 339 lines (+316/-0)
4 files modified
debian/changelog (+7/-0)
debian/patches/font_selection.patch (+286/-0)
debian/patches/git-fix-crash.patch (+21/-0)
debian/patches/series (+2/-0)
To merge this branch: bzr merge lp://staging/~noskcaj/ubuntu/trusty/xfce4-xkb-plugin/lp-733563
Reviewer Review Type Date Requested Status
Logan Rosen Pending
Review via email: mp+214365@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-02-24.

Description of the change

Make xkb-plugin able to change font.

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote : Posted in a previous version of this proposal

thanks

review: Approve
Revision history for this message
Iain Lane (laney) wrote : Posted in a previous version of this proposal

Oops, I commented on the wrong one.

What happens when the user has set `display_textsize' before? It looks like that setting will be lost - is that right and intended?

Revision history for this message
Iain Lane (laney) : Posted in a previous version of this proposal
review: Needs Information
Revision history for this message
Jackson Doak (noskcaj) wrote : Posted in a previous version of this proposal

As far as i know, it's intentional.

On Fri, Mar 7, 2014 at 12:00 AM, Iain Lane <email address hidden> wrote:

> Review: Needs Information
>
>
> --
>
> https://code.launchpad.net/~noskcaj/ubuntu/trusty/xfce4-xkb-plugin/lp-733563/+merge/207853
> You are the owner of lp:~noskcaj/ubuntu/trusty/xfce4-xkb-plugin/lp-733563.
>

lp://staging/~noskcaj/ubuntu/trusty/xfce4-xkb-plugin/lp-733563 updated
38. By Jackson Doak

Add git-fix-crash.patch. LP: #978230

39. By Jackson Doak

Add the patch

Revision history for this message
Jackson Doak (noskcaj) wrote :

Just a warning, i haven't been able to test the patches myself. they should be stable though

Reply
Revision history for this message
Pasi Lallinaho (knome) wrote :

As you told other people have tested the patches, please either make them leave a comment saying the patches are fine or ask that somebody else does the testing.

Reply
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Testable from ppa:timo-jyrinki/ppa (https://launchpad.net/~timo-jyrinki/+archive/ppa)

Reply
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Font_selection.patch needs an FFe, probably won't be granted this cycle.

Git-fix-crash.patch uploaded.

Reply

Unmerged revisions

39. By Jackson Doak

Add the patch

38. By Jackson Doak

Add git-fix-crash.patch. LP: #978230

37. By Jackson Doak

Add font_selection.patch, thanks Ivan Frederiks. LP: #733563

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: