Gnome System Monitor

Merge lp://staging/~noskcaj/gnome-system-monitor/titlebar into lp://staging/~ubuntu-desktop/gnome-system-monitor/ubuntu

titlebar
Merge into ubuntu

Proposed by Jackson Doak on 2014-12-03

Status:

Rejected

Rejected by:

Sebastien Bacher on 2015-03-09

Proposed branch:

lp://staging/~noskcaj/gnome-system-monitor/titlebar

Merge into:

lp://staging/~ubuntu-desktop/gnome-system-monitor/ubuntu

Diff against target:

134 lines (+81/-2)

7 files modified

debian/changelog (+7/-0)
debian/control (+2/-1)
debian/control.in (+2/-1)
debian/patches/series (+2/-0)
debian/patches/traditional-titlebars-pt2.patch (+25/-0)
debian/patches/traditional-titlebars.patch (+40/-0)
debian/source/lintian-overrides (+3/-0)

To merge this branch:

bzr merge lp://staging/~noskcaj/gnome-system-monitor/titlebar

Related bugs:

Bug #1261608: New version uses CSD and doesn't work well under Unity	Wishlist	Fix Released
Bug #1385560: gnome-system-monitor 3.14.1-1 uses headerbar on all DEs	Wishlist	Won't Fix

Link a bug report

Reviewer	Review Type	Date Requested	Status
Sebastien Bacher		2014-12-03	Needs Fixing on 2014-12-05
Review via email: mp+243576@code.staging.launchpad.net

Description of the change

Use traditional titlebars on !gnome. Also adds lintian overrides that were dropped when we synced somehow

Revision history for this message

Sebastien Bacher (seb128) wrote on 2014-12-04:

Thanks, that looks fine, you include lintian changes as well, those should either be documented in the changelog or moved out of this changeset

review: Needs Fixing

Revision history for this message

Sebastien Bacher (seb128) wrote on 2014-12-05:

Thanks, testing that version I found other issues, the bg is transparent which makes the application quite unusable under Unity... that should be fixed before accepting in it vivid as well

review: Needs Fixing

Revision history for this message

Tim Lunn (darkxst) wrote on 2014-12-08:

seb, what is transparent the header bar? I don't see that but I do see incorrect theming.

Adwaita now applies header_bar styling to the titlebar class as well [1], quite a few apps are thus setting the class on header bar widget to "titlebar" rather than "header_bar", this includes atleast cheese, baobab, gnome-contacts, g-s-m and gedit. I guess this change needs to be incorporated into the ubuntu themes.

[1] https://git.gnome.org/browse/gnome-themes-standard/commit/?id=35191720f7676bd8f2b142387b767397bb18354e

lp://staging/~noskcaj/gnome-system-monitor/titlebar updated on 2014-12-08

66. By Jackson Doak on 2014-12-08: Add part 2 patch
67. By Jackson Doak on 2014-12-08: typoe fix

Revision history for this message

Sebastien Bacher (seb128) wrote on 2015-03-09:

the update has been done by somebody else

Unmerged revisions

67. By Jackson Doak on 2014-12-08: typoe fix
66. By Jackson Doak on 2014-12-08: Add part 2 patch
65. By Jackson Doak on 2014-12-03: Add traditional-titlebars.patch. Uses traditional titlebars
on !Gnome. Thanks Tim Lunn. LP: #1385560, #1261608