Merge lp://staging/~nmb/qbzr/qswitch-overload into lp://staging/qbzr
Proposed by
Neil Martinsen-Burrell
| Status: | Merged |
|---|---|
| Approved by: | Alexander Belchenko |
| Approved revision: | 1329 |
| Merged at revision: | 1392 |
| Proposed branch: | lp://staging/~nmb/qbzr/qswitch-overload |
| Merge into: | lp://staging/qbzr |
| Diff against target: |
39 lines (+13/-9) 1 file modified
lib/switch.py (+13/-9) |
| To merge this branch: | bzr merge lp://staging/~nmb/qbzr/qswitch-overload |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alexander Belchenko | Approve | ||
|
Review via email:
|
|||
Description of the change
This allows the process of loading branch names into the combo box to be easily overridden by subclasses of QBzrSwitchWindow. I also added an exec_() method which also calls initial_load so that the dialog may be used correctly as a modal dialog.
To post a comment you must log in.
Revision history for this message
| Alexander Belchenko (bialix) wrote | # |
Revision history for this message
| Alexander Belchenko (bialix) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for this improvement.
I'd prefer to keep the name of the load method as load() not as initial_load() because if we will need to implement refresh then we may ant to re-use the same method to update list of branches. What do you think?