Cable

Merge lp://staging/~nkanaev/cable/master into lp://staging/cable

  1. master
  2. Merge into trunk
Proposed by nkanaev
Status: Merged
Merged at revision: 120
Proposed branch: lp://staging/~nkanaev/cable/master
Merge into: lp://staging/cable
Diff against target: 181 lines (+82/-6)
5 files modified
data/org.pantheon.cable.gschema.xml (+29/-1)
src/Settings/Preferences.vala (+1/-2)
src/Settings/SavedState.vala (+17/-0)
src/Settings/Settings.vala (+3/-1)
src/Widgets/Window.vala (+32/-2)
To merge this branch: bzr merge lp://staging/~nkanaev/cable/master
Reviewer Review Type Date Requested Status
Julien Spautz Needs Fixing
Review via email: mp+180981@code.staging.launchpad.net

Description of the change

Have added functionality to save window size and state. Also servers column width is saved and restored after relaunch.

To post a comment you must log in.
Revision history for this message
Julien Spautz (julien-spautz) wrote :

It seems to work pretty well, a few things to fix:

line 53: remove trailing whitespace

line 101 savedState should be saved_state (and everywhere else in the code)

Thanks for contributing!

review: Needs Fixing
lp://staging/~nkanaev/cable/master updated
114. By nkanaev

code review fixes

Revision history for this message
nkanaev (nkanaev) wrote :

hope everything's fine now

Revision history for this message
Julien Spautz (julien-spautz) wrote :

Thanks! I'll review it soon.

Revision history for this message
Julien Spautz (julien-spautz) wrote :

> hope everything's fine now

It doesn't compile.

/src/Settings/Settings.vala:33.9-33.18: error: The name `savedState' does not exist in the context of `Cable.Settings.init'
        savedState = new Settings.SavedState ();

You forgot some instances of savedState. Please try to compile before pushing a new revision.

review: Needs Fixing
lp://staging/~nkanaev/cable/master updated
115. By nkanaev

bug fix

Revision history for this message
nkanaev (nkanaev) wrote :

my bad. have fixed it

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: