Ubuntu UI Toolkit

Merge lp://staging/~nikwen/ubuntu-ui-toolkit/actionselectionpopover-fix into lp://staging/ubuntu-ui-toolkit/staging

  1. actionselectionpopover-fix
  2. Merge into staging
Proposed by Niklas Wenzel
Status: Merged
Approved by: Zsombor Egri
Approved revision: 1133
Merged at revision: 1380
Proposed branch: lp://staging/~nikwen/ubuntu-ui-toolkit/actionselectionpopover-fix
Merge into: lp://staging/ubuntu-ui-toolkit/staging
Diff against target: 11 lines (+1/-1)
1 file modified
modules/Ubuntu/Components/Popups/ActionSelectionPopover.qml (+1/-1)
To merge this branch: bzr merge lp://staging/~nikwen/ubuntu-ui-toolkit/actionselectionpopover-fix
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Zsombor Egri Approve
Review via email: mp+244647@code.staging.launchpad.net

Description of the change

Fixes https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1395118

Thanks to Nekhelesh for telling me I had to propose this for merging against the staging branch. I wondered why I got no responses when proposing this for trunk. Could this information please be added to the Ubuntu UI Toolkit description on Launchpad?

To post a comment you must log in.
Revision history for this message
Zsombor Egri (zsombi) wrote :

Hei Niklas,

The code looks good to me, we need to kick CI on it to see whether it blows up something.

review: Approve
Revision history for this message
Tim Peeters (tpeeters) wrote :

why should an undefined action be visible?

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
Niklas Wenzel (nikwen) wrote :

Zsombor, thank you very much for merging. :)
Do you know when this will land in the RTM images? We will need it in order to be able to remove the workaround code from the filemanager app. ;)

Tim, I added that piece of code in order not to change the behaviour for any other cases than when the action is not visible.
If you feel that the view should not be shown when the action is undefined, I guess it would be good to create another MP for that.

Revision history for this message
Tim Peeters (tpeeters) wrote :

Niklas, this MR will not land in RTM images. Landing to RTM is a special process for which you need a separate MR to merge this into lp:ubuntu-ui-toolkit/rtm and the bug needs an rtm14 tag. Ping bzoltan for the exact requirements, he will also have to create the landing for this to go to RTM.

Revision history for this message
Niklas Wenzel (nikwen) wrote :

Tim, I sent him an email. Thanks. :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches