Merge lp://staging/~nikwen/ubuntu-terminal-app/scrolling-improvements-2 into lp://staging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

Proposed by Niklas Wenzel
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 93
Merged at revision: 94
Proposed branch: lp://staging/~nikwen/ubuntu-terminal-app/scrolling-improvements-2
Merge into: lp://staging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target: 37 lines (+10/-8)
1 file modified
src/app/qml/TerminalInputArea.qml (+10/-8)
To merge this branch: bzr merge lp://staging/~nikwen/ubuntu-terminal-app/scrolling-improvements-2
Reviewer Review Type Date Requested Status
Filippo Scognamiglio Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+262503@code.staging.launchpad.net

Commit message

Detect whether the swipe is a swipe in x or y direction by comparing the length of the swipe in each direction instead of simply preferring y over x swipes

Description of the change

Detect whether the swipe is a swipe in x or y direction by comparing the length of the swipe in each direction instead of simply preferring y over x swipes.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Filippo Scognamiglio (flscogna) wrote :

Thank you very much for the patch Niklas. Looks really nice to me. :)

review: Approve
Revision history for this message
Niklas Wenzel (nikwen) wrote :

Thank you for merging it, Filippo. :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches