Ubuntu File Manager App

Merge lp://staging/~nikwen/ubuntu-filemanager-app/up-on-backspace into lp://staging/ubuntu-filemanager-app

  1. up-on-backspace
  2. Merge into trunk
Proposed by Niklas Wenzel
Status: Merged
Approved by: Arto Jalkanen
Approved revision: 345
Merged at revision: 356
Proposed branch: lp://staging/~nikwen/ubuntu-filemanager-app/up-on-backspace
Merge into: lp://staging/ubuntu-filemanager-app
Diff against target: 12 lines (+2/-0)
1 file modified
src/app/qml/ui/FolderListPage.qml (+2/-0)
To merge this branch: bzr merge lp://staging/~nikwen/ubuntu-filemanager-app/up-on-backspace
Reviewer Review Type Date Requested Status
Arto Jalkanen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+244348@code.staging.launchpad.net

Commit message

Go up when pressing the backspace key

Description of the change

Go up when pressing the backspace key

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:344
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/431/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/431
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/431/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/53

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/431/rebuild

review: Approve (continuous-integration)
Revision history for this message
Arto Jalkanen (ajalkane) wrote :

Isn't goBack() function do go "back" in history rather than up?

review: Needs Information
lp://staging/~nikwen/ubuntu-filemanager-app/up-on-backspace updated
345. By Niklas Wenzel

Go up instead of going back

Revision history for this message
Niklas Wenzel (nikwen) wrote :

Thank you for looking into this. You are completely right.
I fixed it now. :)

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:345
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/438/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/527
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/527/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/60

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/438/rebuild

review: Approve (continuous-integration)
Revision history for this message
Arto Jalkanen (ajalkane) wrote :

Looks good now, thanks for fast fixing!

review: Approve
Revision history for this message
Niklas Wenzel (nikwen) wrote :

And thank you for merging. :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches