Ubuntu File Manager App

Merge lp://staging/~nikwen/ubuntu-filemanager-app/remove-popover-workaround into lp://staging/ubuntu-filemanager-app

remove-popover-workaround
Merge into trunk

Proposed by Niklas Wenzel on 2015-06-14

Status:

Merged

Approved by:

Niklas Wenzel on 2015-08-28

Approved revision:

422

Merged at revision:

458

Proposed branch:

lp://staging/~nikwen/ubuntu-filemanager-app/remove-popover-workaround

Merge into:

lp://staging/ubuntu-filemanager-app

Diff against target:

27 lines (+0/-17)

1 file modified

src/app/qml/ui/FolderListPage.qml (+0/-17)

To merge this branch:

bzr merge lp://staging/~nikwen/ubuntu-filemanager-app/remove-popover-workaround

Undecided

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Ubuntu Phone Apps Jenkins Bot	continuous-integration		Approve on 2015-08-26
Arto Jalkanen		2015-06-14	Approve on 2015-08-25
Review via email: mp+261909@code.staging.launchpad.net

Commit message

Remove popover workaround for LP: #1395118

Description of the change

Remove popover workaround for LP: #1395118.

This is becoming rather urgent now that the SDK team is creating a new set of popover/dialog components in order to not break things in the filemanager app.

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2015-06-14:

FAILED: Continuous integration, rev:421
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/495/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2930
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2930/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-utopic-amd64-ci/211
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-vivid-amd64-ci/117

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/495/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Niklas Wenzel (nikwen) wrote on 2015-06-24:

The issue here is that the chroot used for testing does not have the UI Toolkit patch. I think one should update those chroots as the patch was added around the second RTM release!

lp://staging/~nikwen/ubuntu-filemanager-app/remove-popover-workaround updated on 2015-08-25