Merge lp://staging/~nikwen/gallery-app/video-delete-message into lp://staging/gallery-app

looks good, thanks

@bfiller: Thanks for reviewing. :)

@nikwen, thank you
artmello, can you test this with the latest and verify it's working correctly

Nothing happening here? This fix has been proposed nearly 3 months ago...

lgtm

We now have two dialogs when deleting a photo from MediaViewer. One about deleting photo from gallery and a new one about deleting the photo only from the Album. We need to apply this change on both dialogs.

Thank you for your review. I think my latest commit should fix the problem. However, I was unable to test it, so someone should do this.

lgtm, thx

This works correctly when you are in the picture view, i.e. you've clicked on a picture or video to view. But it doesn't address the problem when making a selection from the Events view of Photos view. In either of these views if I select a video and then press delete it says "Delete 1 photo". It also should handle the case where there are selections of multiple types, i.e. 2 photos and 3 videos selected

> This works correctly when you are in the picture view, i.e. you've clicked on
> a picture or video to view. But it doesn't address the problem when making a
> selection from the Events view of Photos view. In either of these views if I
> select a video and then press delete it says "Delete 1 photo". It also should
> handle the case where there are selections of multiple types, i.e. 2 photos
> and 3 videos selected

Hi,

Sadly, I will be too busy to be able to implement that within the next two and a half weeks. If you want that feature earlier, feel free to implement it yourself. Moreover, I do not know how to test the gallery app on my device. Simply running it from Qt Creator did not work last time.

we implemented the above in another MR, so this is good to land for the parts it fixes. thanks for the help.

Thanks. :)