uNav

Merge lp://staging/~nik90/unav/change-header-color into lp://staging/unav

change-header-color
Merge into trunk

Proposed by Nekhelesh Ramananthan on 2016-04-10

Status:

Merged

Merged at revision:

Proposed branch:

lp://staging/~nik90/unav/change-header-color

Merge into:

lp://staging/unav

Diff against target:

1032 lines (+644/-51)

21 files modified

nav/img/header/center_onpos.svg (+8/-8)
nav/img/header/center_onpos_light.svg (+8/-8)
nav/img/header/gps_off.svg (+8/-15)
nav/img/header/transparent_center_onpos.svg (+167/-0)
nav/img/header/transparent_center_onpos_light.svg (+167/-0)
nav/img/header/transparent_gps_off.svg (+168/-0)
qml/AboutPage.qml (+1/-1)
qml/Coordinate.qml (+3/-2)
qml/FavoritesPage.qml (+2/-4)
qml/Main.qml (+3/-2)
qml/Nearby.qml (+1/-1)
qml/PoiListPage.qml (+2/-1)
qml/PoiPage.qml (+3/-3)
qml/RouteInfoListPage.qml (+2/-1)
qml/RoutePage.qml (+1/-1)
qml/SearchPage.qml (+3/-2)
qml/SettingsPage.qml (+1/-1)
qml/SharePage.qml (+1/-1)
qml/components/UNavHeader.qml (+28/-0)
qml/components/UNavHeaderButton.qml (+40/-0)
qml/components/UNavPageSection.qml (+27/-0)

To merge this branch:

bzr merge lp://staging/~nik90/unav/change-header-color

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
JkB		2016-04-10	Approve on 2016-04-10
Review via email: mp+291454@code.staging.launchpad.net

Description of the change

Changed header color to blue (taken from uNav app icon)

lp://staging/~nik90/unav/change-header-color updated on 2016-04-10

39. By Nekhelesh Ramananthan on 2016-04-10: Merged lp:unav

Revision history for this message

JkB (joergberroth) wrote on 2016-04-10:

Three things:

1. follow icon color in fullscreen mode now is white and is hard to identify now.

2. Is it possible two change the action select background also? To white for example.
3. It might be nice to change the grey divider to white also.

review: Needs Fixing

Revision history for this message

Nekhelesh Ramananthan (nik90) wrote on 2016-04-10:

> Three things:
>
> 1. follow icon color in fullscreen mode now is white and is hard to identify
> now.
>

Nice catch! I totally missed that since the other header icons were fine.

> 2. Is it possible two change the action select background also? To white for
> example.

I don't changing them to white will be good, since the icon and background will be white. I will set them to lighter blue background color similar to what I did with sections. That said, I am still figuring out how to change the action select background. Will look for a solution.

> 3. It might be nice to change the grey divider to white also.

Good idea. This one is easy to do.

lp://staging/~nik90/unav/change-header-color updated on 2016-04-10

40. By Nekhelesh Ramananthan on 2016-04-10: Changed divider color to white
41. By Nekhelesh Ramananthan on 2016-04-10: Fixed issues pointed by joerg

Revision history for this message

Nekhelesh Ramananthan (nik90) wrote on 2016-04-10:

@Joerg, Fixed all issues you pointed out. Check it out.

Revision history for this message

JkB (joergberroth) wrote on 2016-04-10:

:-)

great work

review: Approve

Revision history for this message

JkB (joergberroth) wrote on 2016-04-10:

Ah a minor thing popped up:

While page is loading, the colors are inconsistent in the header: all grey but the follow icon.

review: Needs Fixing

lp://staging/~nik90/unav/change-header-color updated on 2016-04-10

42. By Nekhelesh Ramananthan on 2016-04-10: Fix invalid color
43. By Nekhelesh Ramananthan on 2016-04-10: Reduce opacity of disabled header buttons

Revision history for this message

Nekhelesh Ramananthan (nik90) wrote on 2016-04-10:

@Joerg, Fixed the issue. Disabled header buttons opacity is lower. This works on all header buttons now properly. Previously the color of a disabled button was changed, but that doesnt work when we use a custom icon, and hence the bug.

Revision history for this message

JkB (joergberroth) wrote on 2016-04-10:

Great work!

review: Approve

lp://staging/~nik90/unav/change-header-color updated on 2016-04-10