Ubuntu UI Toolkit

Merge lp://staging/~nik90/ubuntu-ui-toolkit/fix-slider-bubble-width into lp://staging/ubuntu-ui-toolkit/staging

fix-slider-bubble-width
Merge into staging

Proposed by Nekhelesh Ramananthan on 2015-03-20

Status:

Merged

Approved by:

Tim Peeters on 2015-03-23

Approved revision:

1457

Merged at revision:

1455

Proposed branch:

lp://staging/~nik90/ubuntu-ui-toolkit/fix-slider-bubble-width

Merge into:

lp://staging/ubuntu-ui-toolkit/staging

Diff against target:

50 lines (+29/-1)

2 files modified

examples/ubuntu-ui-toolkit-gallery/Sliders.qml (+25/-0)
modules/Ubuntu/Components/Themes/Ambiance/SliderStyle.qml (+4/-1)

To merge this branch:

bzr merge lp://staging/~nik90/ubuntu-ui-toolkit/fix-slider-bubble-width

Medium

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Approve on 2015-03-23
Tim Peeters		2015-03-20	Approve on 2015-03-23
Review via email: mp+253620@code.staging.launchpad.net

Commit message

Fixes the slider bubble width to be dynamic and dependent on the label width.

Description of the change

This MP fixes the slider bubble width to be dynamic and dependent on the label width instead of being static. This would allow the slider bubble to show values like "medium", "slow" etc without it exceeding the bubble width as shown in https://launchpadlibrarian.net/200688179/Screenshot%20at%2022-13-39.png

lp://staging/~nik90/ubuntu-ui-toolkit/fix-slider-bubble-width updated on 2015-03-20

1456. By Nekhelesh Ramananthan on 2015-03-20: Added two properties

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-20:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1576/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Roman Shchekin (mrqtros) wrote on 2015-03-20:

I think that you should do them private via "__" (double underscore) or internal QtObject. Or you internationally want to show these two new properties to user?

Revision history for this message

Nekhelesh Ramananthan (nik90) wrote on 2015-03-20:

That was my initial thought, but on looking at the other properties in SliderStyle.qml and also at ButtonStyle.qml for reference, they all were not private.

Revision history for this message

Tim Peeters (tpeeters) wrote on 2015-03-20:

bubbleShape is an internal Item for the style, so the added properties are not public. I think it is good like this.

Perhaps you can add a little example of a slider with a larger bubble width in examples/ubuntu-ui-toolkit-gallery/Sliders.qml ?

lp://staging/~nik90/ubuntu-ui-toolkit/fix-slider-bubble-width updated on 2015-03-20