Ubuntu Clock App

Merge lp://staging/~nik90/ubuntu-clock-app/implement-snooze-settings into lp://staging/ubuntu-clock-app

  1. implement-snooze-settings
  2. Merge into trunk
Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 90
Merged at revision: 89
Proposed branch: lp://staging/~nik90/ubuntu-clock-app/implement-snooze-settings
Merge into: lp://staging/ubuntu-clock-app
Diff against target: 517 lines (+273/-134)
4 files modified
app/alarm/AlarmSettingsPage.qml (+224/-134)
backend/modules/Alarm/Settings/alarmsettings.cpp (+30/-0)
backend/modules/Alarm/Settings/alarmsettings.h (+18/-0)
debian/changelog (+1/-0)
To merge this branch: bzr merge lp://staging/~nik90/ubuntu-clock-app/implement-snooze-settings
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Alan Pope 🍺🐧🐱 🦄 (community) Approve
Charles Kerr (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+233622@code.staging.launchpad.net

Commit message

Implement Alarm Snooze settings option as per design spec

Description of the change

Implement Alarm Snooze settings option as per design spec [1]. You will need image 228 or higher to test alarm snooze functionality!

Also do note that this MP is more about exposing alarm snooze settings in the clock app and less about the actual UI itself since I used the settings wireframes to implement it. I was told by the designer that we will be getting proper visual specs for the entire settings page.

[1] https://docs.google.com/presentation/d/1JvDyhsW17d1-Mz8OY1YMBKwfRI2z9qgyRjbujEsxEMk/edit#slide=id.g18895458d_024

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:89
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/446/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/233
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/233/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-utopic-amd64-ci/93

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/446/rebuild

review: Approve (continuous-integration)
lp://staging/~nik90/ubuntu-clock-app/implement-snooze-settings updated
90. By Nekhelesh Ramananthan

merged trunk

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:90
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/451/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/246
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/246/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-utopic-amd64-ci/98

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/451/rebuild

review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

Reviewing the C++ parts of this MP; looks fine.

review: Approve
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

tested on flo. Works well, thanks!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches