Ubuntu Clock App

Merge lp://staging/~nik90/ubuntu-clock-app/fix-alarm-sound-toggle-bug into lp://staging/ubuntu-clock-app

fix-alarm-sound-toggle-bug
Merge into trunk

Proposed by Nekhelesh Ramananthan on 2014-08-24

Status:

Merged

Approved by:

Nekhelesh Ramananthan on 2014-08-25

Approved revision:

Merged at revision:

Proposed branch:

lp://staging/~nik90/ubuntu-clock-app/fix-alarm-sound-toggle-bug

Merge into:

lp://staging/ubuntu-clock-app

Diff against target:

41 lines (+9/-3)

2 files modified

app/alarm/AlarmSound.qml (+7/-3)
debian/changelog (+2/-0)

To merge this branch:

bzr merge lp://staging/~nik90/ubuntu-clock-app/fix-alarm-sound-toggle-bug

Low

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Ubuntu Phone Apps Jenkins Bot	continuous-integration		Approve on 2014-08-25
Victor Thompson		2014-08-24	Approve on 2014-08-25
Review via email: mp+232007@code.staging.launchpad.net

Commit message

Fixed clicking on an alarm sound that is already selected causing an incorrect toggle state

Description of the change

Fixed clicking on an alarm sound that is already selected causing an incorrect toggle state

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-08-24:

PASSED: Continuous integration, rev:66
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/249/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/100
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/100/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-utopic-amd64-ci/249

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/249/rebuild

review: Approve (continuous-integration)

Revision history for this message

Victor Thompson (vthompson) wrote on 2014-08-24:

I have 1 inline comment/question, but this looks good otherwise!

review: Needs Information

Revision history for this message

Nekhelesh Ramananthan (nik90) wrote on 2014-08-24:

> I have 1 inline comment/question, but this looks good otherwise!

Thnx. Removed that line of code. I had it to help distinguish the alarm sound that was selected from others. But I will do after confirming with designer rather than just change it in this MP.

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-08-25:

PASSED: Continuous integration, rev:67
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/250/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/101
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/101/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-utopic-amd64-ci/250