Ubuntu Clock App

Merge lp://staging/~nik90/ubuntu-clock-app/add-first-qmltest into lp://staging/ubuntu-clock-app

add-first-qmltest
Merge into trunk

Proposed by Nekhelesh Ramananthan on 2014-08-13

Status:

Merged

Approved by:

Nekhelesh Ramananthan on 2014-08-19

Approved revision:

Merged at revision:

Proposed branch:

lp://staging/~nik90/ubuntu-clock-app/add-first-qmltest

Merge into:

lp://staging/ubuntu-clock-app

Diff against target:

523 lines (+306/-95)

11 files modified

README (+10/-5)
README.autopilot (+13/-8)
README.developers (+31/-17)
README.unittest (+32/-0)
app/alarm/AlarmLabel.qml (+12/-15)
app/alarm/AlarmRepeat.qml (+3/-0)
debian/changelog (+1/-0)
manifest.json (+1/-1)
tests/unit/tst_alarmLabel.qml (+86/-0)
tests/unit/tst_alarmRepeat.qml (+117/-0)
tests/unit/tst_hellocomponent.qml (+0/-49)

To merge this branch:

bzr merge lp://staging/~nik90/ubuntu-clock-app/add-first-qmltest

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Ubuntu Phone Apps Jenkins Bot	continuous-integration		Approve on 2014-08-19
Michael Zanetti (community)		2014-08-13	Approve on 2014-08-19
Ubuntu Clock Developers		2014-08-13	Pending
Review via email: mp+230702@code.staging.launchpad.net

Commit message

Added the following qml unit tests,
- Test if the back button in the AlarmLabel page is correctly enabled/disabled based on the alarm label
- Test if the alarm label textfield correctly receives the alarm message
- Test if the switches in the AlarmRepeat page are correctly checked based on the alarm dayOfTheWeek value.
- Test if setting the switches in the AlarmRepeat page correctly updates the alarm dayOfTheWeek value.
- Transitioned alarm label page to the new header API.

Description of the change

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-08-13:

PASSED: Continuous integration, rev:57
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/195/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/32
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/32/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-utopic-amd64-ci/195

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/195/rebuild

review: Approve (continuous-integration)

lp://staging/~nik90/ubuntu-clock-app/add-first-qmltest updated on 2014-08-14

58. By Nekhelesh Ramananthan on 2014-08-14: Merged trunk
59. By Nekhelesh Ramananthan on 2014-08-14: Updated debian changelog and click package version in the manifest file
60. By Nekhelesh Ramananthan on 2014-08-14: Added more unit tests

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-08-14:

PASSED: Continuous integration, rev:60
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/196/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/33
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/33/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-utopic-amd64-ci/196

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/196/rebuild

review: Approve (continuous-integration)

lp://staging/~nik90/ubuntu-clock-app/add-first-qmltest updated on 2014-08-14

61. By Nekhelesh Ramananthan on 2014-08-14: Added comment and fixed timing issue in switchStatusUpdatesAlarmObject function

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-08-14:

PASSED: Continuous integration, rev:61
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/197/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/35
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/35/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-utopic-amd64-ci/197

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/197/rebuild

review: Approve (continuous-integration)

Revision history for this message

Leo Arias (elopio) wrote on 2014-08-14:

yay!!! tests!
Can you please add on the README or HACKING file the instructions to run them?
Also, we need to run this tests on jenkins for each MP. That can be in a following branch. We can add them to the make test task, or as autopkgtests. Let me know if you need a hand with this and I'll work with you next week.

lp://staging/~nik90/ubuntu-clock-app/add-first-qmltest updated on 2014-08-14

62. By Nekhelesh Ramananthan on 2014-08-14: Updated readme files with instruction to run ap and unit tests

Revision history for this message

Nekhelesh Ramananthan (nik90) wrote on 2014-08-14:

> yay!!! tests!
> Can you please add on the README or HACKING file the instructions to run them?
> Also, we need to run this tests on jenkins for each MP. That can be in a
> following branch. We can add them to the make test task, or as autopkgtests.
> Let me know if you need a hand with this and I'll work with you next week.

:) I have extensively edited the readme files to accommodate your request. During my weekly clock meeting I informed balloons about the need to have jenkins run the unit tests for each MP. I think it might require enabling things on the jenkins side of things. But I rather let you both discuss it :D

Revision history for this message

Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote on 2014-08-14:

PASSED: Continuous integration, rev:62
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/200/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/38
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/38/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-utopic-amd64-ci/200

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/200/rebuild

review: Approve (continuous-integration)

lp://staging/~nik90/ubuntu-clock-app/add-first-qmltest updated on 2014-08-19

63. By Nekhelesh Ramananthan on 2014-08-19: merged trunk
64. By Nekhelesh Ramananthan on 2014-08-19: Added one more test to alarm repeat page
65. By Nekhelesh Ramananthan on 2014-08-19: merged trunk
66. By Nekhelesh Ramananthan on 2014-08-19: Improved comment