Ubuntu Clock App

Merge lp://staging/~nik90/ubuntu-clock-app/add-fastscroll into lp://staging/ubuntu-clock-app

  1. add-fastscroll
  2. Merge into trunk
Proposed by Nekhelesh Ramananthan
Status: Merged
Merged at revision: 41
Proposed branch: lp://staging/~nik90/ubuntu-clock-app/add-fastscroll
Merge into: lp://staging/ubuntu-clock-app
Diff against target: 601 lines (+509/-2)
8 files modified
app/CMakeLists.txt (+1/-0)
app/clock/ClockPage.qml (+2/-1)
app/upstreamcomponents/CMakeLists.txt (+6/-0)
app/upstreamcomponents/FastScroll.js (+130/-0)
app/upstreamcomponents/FastScroll.qml (+321/-0)
app/upstreamcomponents/README.components (+17/-0)
app/worldclock/WorldCityList.qml (+31/-0)
manifest.json (+1/-1)
To merge this branch: bzr merge lp://staging/~nik90/ubuntu-clock-app/add-fastscroll
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Nicholas Skaggs (community) Approve
Renato Araujo Oliveira Filho Pending
Review via email: mp+229141@code.staging.launchpad.net

Commit message

Added fast scroll to the select a world city page as requested by design

Description of the change

This MP adds fast scroll to the select a world city page. It is not specified in the design spec but on talking to the designers I was asked to implement this similar to the address book app.

I have added all upstream components like FastScroll, PageWithBottomEdge inside the upstreamcomponents folder for easier identification and replacement when they are added to the SDK.

Note 1: It is not required to review FastScroll.js and FastScroll.qml since they haven't been changed and imported straight from upstream address book app.

Note 2: All autopilot tests passed

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:37
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/95/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1245/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-utopic-amd64-ci/95/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/95/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

To fix this you will need this:

renato@ubuntu:~/Projects/phablet/clock-app/add-fastscroll/build$ bzr diff
=== modified file 'app/worldclock/WorldCityList.qml'
--- app/worldclock/WorldCityList.qml 2014-07-28 13:02:59 +0000
+++ app/worldclock/WorldCityList.qml 2014-08-06 18:17:35 +0000
@@ -144,6 +144,10 @@
                         )
         }

+ function getSectionText(index) {
+ return sortedTimeZoneModel.get(index).city.substring(0,1)
+ }
+
         anchors.fill: parent
         anchors.rightMargin: fastScroll.showing ? fastScroll.width - units.gu(1)

You need to implement the function "getSectionText" which returns the letter for each item.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:39
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/115/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1322/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-utopic-amd64-ci/115/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/115/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:40
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/116/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1323/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-utopic-amd64-ci/116/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/116/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:42
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/117/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1325/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-utopic-amd64-ci/117/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/117/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:43
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/120/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1333/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-utopic-amd64-ci/120/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/120/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:43
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/127/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1408/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-utopic-amd64-ci/127/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/127/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

LGTM. I'll note the following qml errors while running:

qml: WARNING! Do not put Page/Tabs/PageStack inside another Page because that causes confusion which is the active page that sets the title and actions.
qml: WARNING! Do not put Page/Tabs/PageStack inside another Page because that causes confusion which is the active page that sets the title and actions.
qml: [LOG]Alarm Page loaded
qml: [LOG]Clock Page loaded
qml: [LOG]Alarm Database loaded
file:///usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Components/Icon10.qml:34:5: QML Image: Failed to get image from provider: image://theme/add
file:///usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Components/Icon10.qml:34:5: QML Image: Failed to get image from provider: image://theme/add
file:///usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Components/Icon10.qml:34:5: QML Image: Failed to get image from provider: image://theme/add
file:///usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Components/Icon10.qml:34:5: QML Image: Failed to get image from provider: image://theme/add
ShaderEffect: Property 'source' is not assigned a valid texture provider (QQuickImage*).

review: Approve
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

file:///usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Components/Icon10.qml:34:5: QML Image: Failed to get image from provider: image://theme/add

We have been getting that error for a while despite no visual errors visible. I informed the sdk devs about this and reported https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1349769. However it seems even after bug is fixed, we still see the error message. I will have a talk with a t1mp about this.

qml: WARNING! Do not put Page/Tabs/PageStack inside another Page because that causes confusion which is the active page that sets the title and actions.
qml: WARNING! Do not put Page/Tabs/PageStack inside another Page because that causes confusion which is the active page that sets the title and actions.

This message is also present in upstream address book. I was told by t1mp that he will suppress the message on the SDK side. He hasn't got to it yet though.

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Thnx for the review. Merging to trunk.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Just noting fastscroll appears during search when the page results are only one page and it's not needed. Upstream doesn't display this behaviour.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-autolanding/7/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1410/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-utopic-amd64-autolanding/7/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:44
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/129/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1412/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-utopic-amd64-ci/129/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/129/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Fixed the fastscroll appearing during search when the page results are only one page.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-autolanding/8/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1420/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-utopic-amd64-autolanding/8/console

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches