Merge lp://staging/~nik90/podbird/6-hide-listened-episodes into lp://staging/podbird

Proposed by Nekhelesh Ramananthan
Status: Merged
Merged at revision: 48
Proposed branch: lp://staging/~nik90/podbird/6-hide-listened-episodes
Merge into: lp://staging/podbird
Prerequisite: lp://staging/~nik90/podbird/5.5-kevin-redesign
Diff against target: 152 lines (+36/-14)
4 files modified
app/podbird.qml (+1/-0)
app/ui/EpisodesPage.qml (+6/-6)
app/ui/SettingsPage.qml (+9/-0)
po/com.mikeasoft.podbird.pot (+20/-8)
To merge this branch: bzr merge lp://staging/~nik90/podbird/6-hide-listened-episodes
Reviewer Review Type Date Requested Status
Michael Sheldon Approve
Nekhelesh Ramananthan Pending
Review via email: mp+255159@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-03-31.

Description of the change

Added settings option to hide listened episodes. It basically filters the episodes shown in the episodes page when the setting is true. (Disabled by default).

To post a comment you must log in.
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote : Posted in a previous version of this proposal

Please check if the following strings are grammatically correct,

25 + title: podbird.settings.hideListened ? i18n.tr("No more episodes") : i18n.tr("No Episodes found")
26 + subTitle: podbird.settings.hideListened ? i18n.tr("All episodes have been listened to.") : i18n.tr("No episodes found matching the search term.")

review: Needs Information
55. By Nekhelesh Ramananthan

merged prerequisite lp:~nik90/podbird/5.5-kevin-redesign

56. By Nekhelesh Ramananthan

merged prerequisite lp:~nik90/podbird/5.5-kevin-redesign

57. By Nekhelesh Ramananthan

merged prerequisite lp:~nik90/podbird/5.5-kevin-redesign

58. By Nekhelesh Ramananthan

Merged prerequisite dynamic loading of tabs feature

59. By Nekhelesh Ramananthan

merged prerequisite

60. By Nekhelesh Ramananthan

merged prerequsite

61. By Nekhelesh Ramananthan

merged prerequisite

62. By Nekhelesh Ramananthan

merged prerequisite

63. By Nekhelesh Ramananthan

merged

64. By Nekhelesh Ramananthan

Merged prerequisite

65. By Nekhelesh Ramananthan

merged prerequisite

66. By Nekhelesh Ramananthan

merged prerequisite

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Looks good, I spotted some inconsistent capitalisation of the "No Episodes found" string (which was there before this MR) and fixed that quickly whilst merging this.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches