Merge lp://staging/~nijaba/vmbuilder/rawsize-lp303882 into lp://staging/vmbuilder/trunk
Proposed by
Nick Barcet
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~nijaba/vmbuilder/rawsize-lp303882 |
| Merge into: | lp://staging/vmbuilder/trunk |
| To merge this branch: | bzr merge lp://staging/~nijaba/vmbuilder/rawsize-lp303882 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Soren Hansen | Needs Fixing | ||
|
Review via email:
|
|||
To post a comment you must log in.
Unmerged revisions
- 279. By Nick Barcet
-
* raw can now be specified multiple times
* preallocated image size is not assumed to 5G anymore (LP: #303882)
Nick,
this will fail if only one --raw argument is passed, but VM expects more than one size (if there's multiple disks), since you unconditionally do a vm.raw[diskid]. Either rework the patch to only use the value if it is actually given, or make it check if the right number of arguments are given.