Juju Charms Collection
roundcube package

Merge lp://staging/~nijaba/charms/oneiric/roundcube/new-scp into lp://staging/charms/oneiric/roundcube

  1. Oneiric (11.10)
  2. new-scp
  3. Merge into trunk
Proposed by Nick Barcet
Status: Rejected
Rejected by: Jorge Castro
Proposed branch: lp://staging/~nijaba/charms/oneiric/roundcube/new-scp
Merge into: lp://staging/charms/oneiric/roundcube
Diff against target: 336 lines (+79/-147)
5 files modified
hooks/install (+1/-1)
hooks/peer-relation-all (+17/-47)
hooks/peer-relation-departed (+12/-0)
hooks/roundcube-common (+48/-98)
revision (+1/-1)
To merge this branch: bzr merge lp://staging/~nijaba/charms/oneiric/roundcube/new-scp
Reviewer Review Type Date Requested Status
Juan L. Negron (community) Disapprove
Review via email: mp+88239@code.staging.launchpad.net

Description of the change

This branch fixes a few bugs and uses the new charm-helper copy functions instead of its own

To post a comment you must log in.
Revision history for this message
Juan L. Negron (negronjl) wrote :

I cannot review this as I am unable to branch lp:charms/oneiric/roundcube at the moment.
I'll try to investigate why ( I suspect this is a by-product of the switch from oneiric to precise ).

-Juan

Revision history for this message
Juan L. Negron (negronjl) wrote :

Both Proposed Branch and Merge Into branches are gone ...

I cannot review them ... therefore I have to reject this.

Nick:

If you moved this code somewhere else and want me to review it, let me know. I think you'll have to do another MP.

-Juan

review: Disapprove
Revision history for this message
Kapil Thangavelu (hazmat) wrote :

There's some discussion on the lists of this issue, namely majority of
oneiric official charms branches are mia atm.

On Wed, May 23, 2012 at 12:38 PM, Juan L. Negron
<email address hidden>wrote:

> I cannot review this as I am unable to branch lp:charms/oneiric/roundcube
> at the moment.
> I'll try to investigate why ( I suspect this is a by-product of the switch
> from oneiric to precise ).
>
> -Juan
> --
>
> https://code.launchpad.net/~nijaba/charms/oneiric/roundcube/new-scp/+merge/88239
> Your team charmers is requested to review the proposed merge of
> lp:~nijaba/charms/oneiric/roundcube/new-scp into
> lp:charms/oneiric/roundcube.
>

Unmerged revisions

34. By Nick Barcet

going around a weird output behaviour of juju-log on lxc

33. By Nick Barcet

allow execution of peer-relation-departed

32. By Nick Barcet

use the official ppa now that my changes have been merged

31. By Nick Barcet

missing $

30. By Nick Barcet

[ -e ] is true, needs to protect against that

29. By Nick Barcet

add peer-relation-departed and call to ch_sshd_set_root_login

28. By Nick Barcet

now fully working with ch_peer_copy

27. By Nick Barcet

removing an uneeded test

26. By Nick Barcet

update to use the new ch_peer_scp function

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: