Merge lp://staging/~niemeyer/lbox/use-filepath-dir into lp://staging/lbox
Proposed by
Gustavo Niemeyer
Status: | Merged |
---|---|
Merged at revision: | 51 |
Proposed branch: | lp://staging/~niemeyer/lbox/use-filepath-dir |
Merge into: | lp://staging/lbox |
Diff against target: |
19 lines (+2/-2) 2 files modified
.lbox (+1/-1) main.go (+1/-1) |
To merge this branch: | bzr merge lp://staging/~niemeyer/lbox/use-filepath-dir |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gustavo Niemeyer | Pending | ||
Review via email: mp+111113@code.staging.launchpad.net |
Description of the change
Use filepath.Dir.
To post a comment you must log in.
Reviewers: mp+111113_ code.launchpad. net,
Message:
Please take a look.
Description:
Use filepath.Dir.
https:/ /code.launchpad .net/~niemeyer/ lbox/use- filepath- dir/+merge/ 111113
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/6303104/
Affected files:
M .lbox
A [revision details]
M main.go
Index: .lbox
=== modified file '.lbox'
--- .lbox 2012-03-14 13:15:27 +0000
+++ .lbox 2012-06-19 21:30:03 +0000
@@ -1,1 +1,1 @@
-propose -for=lp:lbox
+propose -for=lp:lbox -cr
Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>
Index: main.go
=== modified file 'main.go'
--- main.go 2011-12-19 17:58:50 +0000
+++ main.go 2012-06-19 21:30:03 +0000
@@ -87,7 +87,7 @@
return
}
last := dir
- dir, _ = filepath.Split(dir)
+ dir = filepath.Dir(dir)
if dir == last {
return
}