Merge lp://staging/~niemeyer/lbox/long-summary-review into lp://staging/lbox

Proposed by Gustavo Niemeyer
Status: Merged
Merged at revision: 50
Proposed branch: lp://staging/~niemeyer/lbox/long-summary-review
Merge into: lp://staging/lbox
Prerequisite: lp://staging/~niemeyer/lbox/long-summary
Diff against target: 21 lines (+2/-2)
1 file modified
text.go (+2/-2)
To merge this branch: bzr merge lp://staging/~niemeyer/lbox/long-summary-review
Reviewer Review Type Date Requested Status
Gustavo Niemeyer Pending
Review via email: mp+111106@code.staging.launchpad.net

Description of the change

Applying review comments by Martin Packman.

https://codereview.appspot.com/6305112/

To post a comment you must log in.
Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

Please take a look.

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

Reviewers: mp+111106_code.launchpad.net,

Message:
Please take a look.

Description:
Applying review comments by Martin Packman.

https://code.launchpad.net/~niemeyer/lbox/long-summary-review/+merge/111106

Requires:
https://code.launchpad.net/~niemeyer/lbox/long-summary/+merge/111099

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/6305112/

Affected files:
   A [revision details]
   M text.go

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>

Index: text.go
=== modified file 'text.go'
--- text.go 2012-06-19 20:09:16 +0000
+++ text.go 2012-06-19 21:12:23 +0000
@@ -25,7 +25,7 @@
  }

  func (t *Log) SummaryTooLong() bool {
- return len(t.Summary) > 72
+ return len(t.Summary) > 50
  }

  func (t *Log) String() string {
@@ -38,7 +38,7 @@
  const (
   templateSummary = "<enter change summary here>"
   templateDescription = "<enter change description here if sensible>"
- templateTooLong = "[TOO LONG] "
+ templateTooLong = "TOO LONG (>50): "
  )

  func editLog(oldLog *Log) (newLog *Log, err error) {

52. By Gustavo Niemeyer

Merged from trunk.

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :
Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

*** Submitted:

Applying review comments by Martin Packman.

R=
CC=
https://codereview.appspot.com/6305112

https://codereview.appspot.com/6305112/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: