Code review comment for lp://staging/~niemeyer/juju-core/func-validators

*** Submitted:

charm: use functions for validation

R=dimitern, danilo.segan
CC=
https://codereview.appspot.com/8585043

https://codereview.appspot.com/8585043/diff/1/charm/url_test.go
File charm/url_test.go (left):

https://codereview.appspot.com/8585043/diff/1/charm/url_test.go#oldcode121
charm/url_test.go:121: var validRegexpTests = []struct {
On 2013/04/09 18:16:37, danilo.segan wrote:
> It's probably worthwhile to rename this to validCheckerTests as well
(unless I
> am missing something).

Indeed, thanks.

https://codereview.appspot.com/8585043/diff/1/charm/url_test.go#oldcode166
charm/url_test.go:166: for i, t := range validRegexpTests {
On 2013/04/09 18:16:37, danilo.segan wrote:
> See above.

Done.

https://codereview.appspot.com/8585043/