Merge lp://staging/~niemeyer/gozk/fix-exists into lp://staging/gozk/zookeeper
Proposed by
Gustavo Niemeyer
Status: | Merged |
---|---|
Merged at revision: | 29 |
Proposed branch: | lp://staging/~niemeyer/gozk/fix-exists |
Merge into: | lp://staging/gozk/zookeeper |
Diff against target: |
30 lines (+3/-1) 3 files modified
.lbox (+1/-0) zk.go (+1/-1) zk_test.go (+1/-0) |
To merge this branch: | bzr merge lp://staging/~niemeyer/gozk/fix-exists |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
The Go Language Gophers | Pending | ||
Review via email: mp+93266@code.staging.launchpad.net |
Description of the change
Fix Exists.
To post a comment you must log in.
Reviewers: mp+93266_ code.launchpad. net,
Message:
Please take a look.
Description:
https:/ /code.launchpad .net/~niemeyer/ gozk/fix- exists/ +merge/ 93266
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/5673057/
Affected files:
A .lbox
M zk.go
M zk_test.go
Index: .lbox
=== <email address hidden> >
<email address hidden>
=== added file '.lbox'
--- .lbox 1970-01-01 00:00:00 +0000
+++ .lbox 2012-02-15 18:05:29 +0000
@@ -0,0 +1,1 @@
+propose -cr -for lp:gozk/zookeeper
Index: zk.go unsafe. Pointer( cpath))
=== <email address hidden> >
<email address hidden>
=== modified file 'zk.go'
--- zk.go 2012-02-15 17:18:34 +0000
+++ zk.go 2012-02-15 17:51:23 +0000
@@ -574,7 +574,7 @@
defer C.free(
var cstat Stat conn.handle, cpath, nil, nil, &stat.c) conn.handle, cpath, nil, nil, &cstat.c)
- rc, cerr := C.zoo_wexists(
+ rc, cerr := C.zoo_wexists(
// We diverge a bit from the usual here: a ZNONODE is not an error
// for an exists call, otherwise every Exists call would have to check
Index: zk_test.go
=== <email address hidden> >
<email address hidden>
=== modified file 'zk_test.go'
--- zk_test.go 2012-02-15 17:18:34 +0000
+++ zk_test.go 2012-02-15 17:51:23 +0000
@@ -399,6 +399,7 @@
stat, err = conn.Exists( "/zookeeper" ) stat.NumChildre n(), Equals, 1)
c.Assert(err, IsNil)
+ c.Assert(
}
func (s *S) TestExistsAndWa tch(c *C) {