Merge lp://staging/~niedbalski/uvtool/fixes-lp-1428674 into lp://staging/~uvtool-dev/uvtool/trunk
Proposed by
Jorge Niedbalski
| Status: | Rejected |
|---|---|
| Rejected by: | Robie Basak |
| Proposed branch: | lp://staging/~niedbalski/uvtool/fixes-lp-1428674 |
| Merge into: | lp://staging/~uvtool-dev/uvtool/trunk |
| Diff against target: |
36 lines (+16/-5) 1 file modified
uvtool/libvirt/__init__.py (+16/-5) |
| To merge this branch: | bzr merge lp://staging/~niedbalski/uvtool/fixes-lp-1428674 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Robie Basak | Needs Fixing | ||
| uvtool development | Pending | ||
|
Review via email:
|
|||
Description of the change
Proposed fix for #1428674
To post a comment you must log in.
Revision history for this message
| Robie Basak (racb) wrote | # |
Unmerged revisions
- 94. By Jorge Niedbalski
-
Fixed file size
- 93. By Jorge Niedbalski
-
[niedbalski, r=] Fixes bugs LP #1428674 and LP #1420142
- Since libvirt v1.2.11 though, libvirt adds --leasefile-ro which stops it
updating the dnsmasq lease file and makes libvirt store the leases itself.
- This patch uses /proc/net/arp as a fallback in case no leasefile exist.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This doesn't fix "uvt-kvm wait", which runs inotify on the default.leases file. Commented in the bug, as I think that we need to discuss the general approach.
A couple of comments on this MP specifically:
Why 1 instead of 0 for the file size? I presume you need it because you added another commit changing it, but I'd like to see a comment in the code explaining why.
1, 2, 3 and 0 as arguments to _filter_mac should be named constants or carry an explanation of what they are some other way.