Merge lp://staging/~niedbalski/ubuntu/vivid/squid3/fix-pinger-icmp into lp://staging/ubuntu/vivid/squid3
Proposed by
Jorge Niedbalski
| Status: | Merged |
|---|---|
| Merge reported by: | Iain Lane |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~niedbalski/ubuntu/vivid/squid3/fix-pinger-icmp |
| Merge into: | lp://staging/ubuntu/vivid/squid3 |
| Diff against target: |
282 lines (+262/-0) 3 files modified
debian/changelog (+6/-0) debian/patches/fix-icmp-pinger-icmp4-6.patch (+255/-0) debian/patches/series (+1/-0) |
| To merge this branch: | bzr merge lp://staging/~niedbalski/ubuntu/vivid/squid3/fix-pinger-icmp |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Iain Lane (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Fixes LP: #1384943
Description: Fix various ICMP handling issues in Squid pinger
* ICMP code type logging display could over-read the registered type
string arrays.
* Malformed ICMP packets were accepted into processing with undefined
and potentially nasty results.
Both sets of flaws can result in pinger segmentation fault and halting
the Squid functionality relying on pinger for correct operation.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks, uploaded. It'd probably be good to merge the newer upstream version that Debian has.