Ubuntu
lightdm package

Merge lp://staging/~niedbalski/ubuntu/vivid/lightdm/disable-nocpp into lp://staging/ubuntu/vivid/lightdm

  1. Vivid (15.04)
  2. disable-nocpp
  3. Merge into vivid
Proposed by Jorge Niedbalski
Status: Work in progress
Proposed branch: lp://staging/~niedbalski/ubuntu/vivid/lightdm/disable-nocpp
Merge into: lp://staging/ubuntu/vivid/lightdm
Diff against target: 32 lines (+11/-2)
2 files modified
debian/changelog (+9/-0)
debian/lightdm-session (+2/-2)
To merge this branch: bzr merge lp://staging/~niedbalski/ubuntu/vivid/lightdm/disable-nocpp
Reviewer Review Type Date Requested Status
Robert Ancell Pending
Ubuntu branches Pending
Review via email: mp+253455@code.staging.launchpad.net

Description of the change

Most user doesn't have a .Xresources file on the system, the few who have one, by enabling the cpp pre-processor will ended up with a _very_ minimal performance impact on startup (.00000 magnitude order) and that simple change fixes (LP: #1244578) and (LP: #1084885).

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, could you propose the change against lp:lightdm which is the upstream vcs?

Reply
Revision history for this message
Daniel Holbach (dholbach) wrote :

Marked as WIP, Robert: can you maybe coordinate with Jorge?

Reply
Revision history for this message
Robert Ancell (robert-ancell) wrote :

This is currently merged into trunk via https://code.launchpad.net/~cqql/lightdm/cpp/+merge/257486. So I think this is obsolete?

Reply

Unmerged revisions

163. By Jorge Niedbalski

debian/lightdm.session: Removed the '-nocpp' option on user defined .Xresources.

- There is no an efficient way for checking if cpp macros already exists.
- The 'nocpp' option break backcompatibility and doesn't affects default
ubuntu installations.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches