simplestreams

Merge lp://staging/~niedbalski/simplestreams/trunk into lp://staging/~smoser/simplestreams/trunk

  1. trunk
  2. Merge into trunk
Proposed by Jorge Niedbalski
Status: Rejected
Rejected by: Scott Moser
Proposed branch: lp://staging/~niedbalski/simplestreams/trunk
Merge into: lp://staging/~smoser/simplestreams/trunk
Diff against target: 35 lines (+14/-4)
1 file modified
simplestreams/contentsource.py (+14/-4)
To merge this branch: bzr merge lp://staging/~niedbalski/simplestreams/trunk
Reviewer Review Type Date Requested Status
Scott Moser Pending
Review via email: mp+218860@code.staging.launchpad.net

Description of the change

Added a new method `read_iterable` that exposes a generator interface
for chunk reads.

This method is being used for tracking the current download
progress on uvtool-simplestreams.

To post a comment you must log in.
Revision history for this message
Scott Moser (smoser) wrote :

i believe that youfound the existing progress callbacks acceptable.
please re-open if not.

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

smoser,

Would be beneficial if you can merge this request, since there are some tools (like uvt-simplestreams) on which modifying the mirror class for using the progress callbacks turns a bit complicated.

Revision history for this message
Scott Moser (smoser) wrote :

i've marked this as rejected.
I'm not entirely opposed to it, but would like explanation.
re-open or re-submit if you'd like.

Unmerged revisions

345. By Jorge Niedbalski

[contentsource] added read_iterable method for being used on iterative downloads

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: