python-jujuclient

Merge lp://staging/~niedbalski/python-jujuclient/lp-1456655 into lp://staging/python-jujuclient

  1. lp-1456655
  2. Merge into trunk
Proposed by Jorge Niedbalski
Status: Merged
Merged at revision: 58
Proposed branch: lp://staging/~niedbalski/python-jujuclient/lp-1456655
Merge into: lp://staging/python-jujuclient
Diff against target: 109 lines (+29/-24)
6 files modified
HACKING.rst (+3/-11)
Makefile (+0/-11)
docs/source/conf.py (+1/-1)
setup.py (+1/-1)
test-requirements.txt (+3/-0)
tox.ini (+21/-0)
To merge this branch: bzr merge lp://staging/~niedbalski/python-jujuclient/lp-1456655
Reviewer Review Type Date Requested Status
Tim Van Steenburgh (community) Approve
Felipe Reyes (community) Approve
Review via email: mp+259506@code.staging.launchpad.net

Description of the change

Fixes bug lp: #1456655

To post a comment you must log in.
lp://staging/~niedbalski/python-jujuclient/lp-1456655 updated
63. By Jorge Niedbalski

MIssing test-requirements.txt

64. By Jorge Niedbalski

Missing test_jujuclient.py

Revision history for this message
Felipe Reyes (freyes) wrote :

Hi Jorge,

Tox! excellent, I just left a couple of minor comments, and beside those you should update HACKING.rst to document that we are using tox and how to run the test suite.

Thanks,

review: Needs Fixing
lp://staging/~niedbalski/python-jujuclient/lp-1456655 updated
65. By Jorge Niedbalski

Addressed @tvansteenburgh and @freyes comments

66. By Jorge Niedbalski

Re-added Makefile with deprecation notice

Revision history for this message
Felipe Reyes (freyes) wrote :

Jorge, LGTM, thanks for addressing my feedback.

Best,

review: Approve
Revision history for this message
Tim Van Steenburgh (tvansteenburgh) wrote :

LGTM, thanks Jorge!

review: Approve
Revision history for this message
Kapil Thangavelu (hazmat) wrote :

@tim ugh. yeah. i see now that looks like a copy and paste error from run all on machines. thanks jorge!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches