golxc

Merge lp://staging/~niedbalski/golxc/fix-1329049 into lp://staging/golxc

  1. fix-1329049
  2. Merge into trunk
Proposed by Jorge Niedbalski
Status: Merged
Merged at revision: 10
Proposed branch: lp://staging/~niedbalski/golxc/fix-1329049
Merge into: lp://staging/golxc
Diff against target: 74 lines (+32/-2)
3 files modified
golxc.go (+14/-1)
golxc_test.go (+17/-0)
network.go (+1/-1)
To merge this branch: bzr merge lp://staging/~niedbalski/golxc/fix-1329049
Reviewer Review Type Date Requested Status
Tim Penhey (community) Approve
Frank Mueller Pending
Review via email: mp+225584@code.staging.launchpad.net

Description of the change

- Added function getDefaultLXCContainerDir , first executes lxc-config lxc.lxcpath if this fails, then DefaultLXCDir is used.
 - Required fix to LP:#1329049

To post a comment you must log in.
lp://staging/~niedbalski/golxc/fix-1329049 updated
11. By Jorge Niedbalski

Small typo fix on method comment

Revision history for this message
Tim Penhey (thumper) wrote :

Can we please have a test?

You should be able to mock out the lxc-config executable.

review: Needs Fixing
lp://staging/~niedbalski/golxc/fix-1329049 updated
12. By Jorge Niedbalski

Added UtilsSuite, implemented TestGetDefaultLXCContainerDir test for validate changes.

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

Hey @thumper,

Added tests to validate this changes.

lp://staging/~niedbalski/golxc/fix-1329049 updated
13. By Jorge Niedbalski

- Minor formatting issues.

Revision history for this message
Tim Penhey (thumper) wrote :

Added comments inline, let's see how they look.

lp://staging/~niedbalski/golxc/fix-1329049 updated
14. By Jorge Niedbalski

- Fixes according to @thumper comments.

Revision history for this message
Tim Penhey (thumper) wrote :

LGTM, thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches