Merge lp://staging/~niedbalski/charm-helpers/lp1667478 into lp://staging/charm-helpers

Proposed by Jorge Niedbalski
Status: Merged
Merged at revision: 696
Proposed branch: lp://staging/~niedbalski/charm-helpers/lp1667478
Merge into: lp://staging/charm-helpers
Diff against target: 248 lines (+231/-0)
3 files modified
charmhelpers/contrib/openstack/keystone.py (+144/-0)
test_requirements.txt (+1/-0)
tests/contrib/openstack/test_keystone_utils.py (+86/-0)
To merge this branch: bzr merge lp://staging/~niedbalski/charm-helpers/lp1667478
Reviewer Review Type Date Requested Status
Felipe Reyes (community) Needs Fixing
Billy Olsen Approve
Shane Peters (community) Approve
Review via email: mp+318288@code.staging.launchpad.net

Description of the change

[Description]

This change is a initial import/transplant from the charm-keystone/hooks/manager.py class,
the main purpose of this utility class is to determine if a service already exists
on the catalog, however, the code could be extended for adding other functionality as well.

This is part of the fix required for LP: #1667478

To post a comment you must log in.
Revision history for this message
Shane Peters (shaner) wrote :

LGTM!

review: Approve
Revision history for this message
Billy Olsen (billy-olsen) wrote :

LGTM

review: Approve
Revision history for this message
Felipe Reyes (freyes) :
review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches