Merge lp://staging/~niedbalski/charm-helpers/lp1667478-2 into lp://staging/charm-helpers

Proposed by Jorge Niedbalski
Status: Merged
Merged at revision: 699
Proposed branch: lp://staging/~niedbalski/charm-helpers/lp1667478-2
Merge into: lp://staging/charm-helpers
Diff against target: 199 lines (+93/-23)
2 files modified
charmhelpers/contrib/openstack/keystone.py (+45/-11)
tests/contrib/openstack/test_keystone_utils.py (+48/-12)
To merge this branch: bzr merge lp://staging/~niedbalski/charm-helpers/lp1667478-2
Reviewer Review Type Date Requested Status
Shane Peters (community) Approve
Felipe Reyes (community) Approve
Review via email: mp+318505@code.staging.launchpad.net

Description of the change

This commit adds the following changes:

  1) Support to load a keystone manager from a identityservice context.
  2) The service_exists function ensures that service_type and service_name are
  separated terms to search by.

To post a comment you must log in.
706. By Jorge Niedbalski

Properly test the identityservicecontext class

Revision history for this message
Felipe Reyes (freyes) wrote :

LGTM! thanks jorge

review: Approve
Revision history for this message
Shane Peters (shaner) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches