Merge lp://staging/~niedbalski/charm-helpers/fix-1699565 into lp://staging/charm-helpers
Proposed by
Jorge Niedbalski
Status: | Superseded |
---|---|
Proposed branch: | lp://staging/~niedbalski/charm-helpers/fix-1699565 |
Merge into: | lp://staging/charm-helpers |
Diff against target: |
71 lines (+46/-0) 2 files modified
charmhelpers/contrib/openstack/utils.py (+12/-0) tests/contrib/openstack/test_os_utils.py (+34/-0) |
To merge this branch: | bzr merge lp://staging/~niedbalski/charm-helpers/fix-1699565 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Felipe Reyes (community) | Approve | ||
Review via email: mp+326111@code.staging.launchpad.net |
This proposal has been superseded by a proposal from 2017-06-22.
Description of the change
Partial fix required for LP: #1699565.
To post a comment you must log in.
Does this really need to be in charm-helpers? It seems to be something that could just be done in the glance charm. The function 'update_ policy( ...)' would have to also be mocked out in the glance charm to test the code that it will be using.
Are you seeing other use cases that means that it will be used across many charms? Thanks.