Merge lp://staging/~nicolas-espina/dockmanager/dockmanager-helpers into lp://staging/dockmanager

Proposed by Nicolas
Status: Needs review
Proposed branch: lp://staging/~nicolas-espina/dockmanager/dockmanager-helpers
Merge into: lp://staging/dockmanager
Diff against target: 245 lines (+114/-23)
2 files modified
scripts/emesene_control.py (+44/-1)
scripts/pidgin_control.py (+70/-22)
To merge this branch: bzr merge lp://staging/~nicolas-espina/dockmanager/dockmanager-helpers
Reviewer Review Type Date Requested Status
Rico Tzschichholz Needs Information
Michal Hruby Pending
Review via email: mp+33950@code.staging.launchpad.net

Description of the change

I update the Pidgin and Emesene helpers, now the two applications uses the message count, menu entries in the dock menu to change status and the icon in the dock changes to show the actual status of the app.

This is my first approach in bzr+launchpad, so if you need something else just ask me, i have a diff file but i think that launchad makes a diff for you when i finish to send this

To post a comment you must log in.
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Creating and adding the menu entries only once is more stable, but you removed with this change the selective showing of them depending on the current connection state.

So at least the Connected/Disconnected status should take effect on what menu items are shown?

review: Needs Information
Revision history for this message
Nicolas (nicolas-espina) wrote :

I remove the change of states depending of the state of the IM to follow
the behavior of emesene and pidgin... They show ALL the status and no
depends of the actual. And i remove that behavior too because sometimes (and
for a strange reason that i never know) some statuses appears more than
once, so my decision to make them free of bugs was to remove that and show
all the status... BTW, the skype helper add all the entries and is really
nice

Revision history for this message
Nicolas (nicolas-espina) wrote :

I remove the change of states depending of the state of the IM to follow the behavior of emesene and pidgin... They show ALL the status and no depends of the actual. And i remove that behavior too because sometimes (and for a strange reason that i never know) some statuses appears more than once, so my decision to make them free of bugs was to remove that and show all the status... BTW, the skype helper add all the entries and is really nice

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

You might want to add some strings constants like the skype helper has and replace the duplicated usage of these icon paths. This also makes it easier to fix these hardcoded paths in future somehow.

review: Needs Fixing
Revision history for this message
Nicolas (nicolas-espina) wrote :

Ok... I have a really important exam so in the next week i finish well the code looking for the skype helper... Thanks for the help and in a close future you have notice of my helpers :D ... Cheers

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

@Nicolas: I hope you are going to finish your work. :)

review: Needs Information
Revision history for this message
Nicolas (nicolas-espina) wrote :

Ups... I forgot this completlly.. Really sorry for that... I finish all my
exams in exactly one week and i finish this =)

Sorry again

2010/12/6 Rico Tzschichholz <email address hidden>

> Review: Needs Information
> @Nicolas: I hope you are going to finish your work. :)
> --
>
> https://code.launchpad.net/~nicolas-espina/dockmanager/dockmanager-helpers/+merge/33950
> You are the owner of lp:~nicolas-espina/dockmanager/dockmanager-helpers.
>

68. By Nicolas

Now the icons are retrieved first in constants

Revision history for this message
Nicolas (nicolas-espina) wrote :

Rico: I fix the problem that my scripts have with the icon retrieves... Now i use the constants like you say... I hope that now everything is fine and ready to merge :D

Unmerged revisions

68. By Nicolas

Now the icons are retrieved first in constants

67. By Nicolas

Now pidgin show the status on Docky

66. By Nicolas

Fixed menu entries in the pidgin helper

65. By Nicolas

Updated emesene helper with some cool stuff

64. By Nicolas

First merge of the main branch

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: