Merge lp://staging/~nick-moffitt/charms/precise/mysql/mysql-shopt-is-a-shell-builtin into lp://staging/charms/mysql
Proposed by
Nick Moffitt
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 122 | ||||
| Proposed branch: | lp://staging/~nick-moffitt/charms/precise/mysql/mysql-shopt-is-a-shell-builtin | ||||
| Merge into: | lp://staging/charms/mysql | ||||
| Diff against target: |
12 lines (+0/-2) 1 file modified
hooks/install (+0/-2) |
||||
| To merge this branch: | bzr merge lp://staging/~nick-moffitt/charms/precise/mysql/mysql-shopt-is-a-shell-builtin | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Marco Ceppi (community) | Approve | ||
| Edward Hope-Morley | Approve | ||
| James Page | Approve | ||
| charmers | Pending | ||
|
Review via email:
|
|||
Description of the change
It looks like someone converted a shell script hook over to Python rather literally, and included a call-out to a shell builtin. This causes the mysql charm in precise to fail pretty catastrophically in the install hook right now.
fixes bug #1315022
To post a comment you must log in.
Revision history for this message
| Jacek Nykis (jacekn) wrote | # |
Revision history for this message
| James Page (james-page) | # |
review:
Approve
Revision history for this message
| Edward Hope-Morley (hopem) wrote | # |
Revision history for this message
| Edward Hope-Morley (hopem) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
It failed for me as well, this change makes charm usable again