Merge lp://staging/~nick-moffitt/charm-helpers/nrpe-servicegroup-comments into lp://staging/charm-helpers
Proposed by
Nick Moffitt
| Status: | Merged |
|---|---|
| Merged at revision: | 744 |
| Proposed branch: | lp://staging/~nick-moffitt/charm-helpers/nrpe-servicegroup-comments |
| Merge into: | lp://staging/charm-helpers |
| Diff against target: |
31 lines (+10/-0) 2 files modified
charmhelpers/contrib/charmsupport/nrpe.py (+7/-0) tests/contrib/charmsupport/test_nrpe.py (+3/-0) |
| To merge this branch: | bzr merge lp://staging/~nick-moffitt/charm-helpers/nrpe-servicegroup-comments |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Barry Price | Approve | ||
| Stuart Bishop (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
I'm working on better ways to collect nagios checks than the current rsync model, and right now that means as much info as possible goes into the nrpe configs. The result is that servicegroup data need to be written in specially-formatted comments in the nrpe.d config files, just before the alerts they describe.
To post a comment you must log in.
Revision history for this message
| Nick Moffitt (nick-moffitt) wrote | # |
Revision history for this message
| Nick Moffitt (nick-moffitt) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
specially-formatted comments probably need a comment in nrpe.py explaining that they are specially-
Otherwise, sure. I've done worse... but it would be nice if you could store this data somewhere else in a real format.