Merge lp://staging/~nick-moffitt/assets-bundler/use-jinja2-not-sed into lp://staging/assets-bundler

Proposed by Nick Moffitt
Status: Needs review
Proposed branch: lp://staging/~nick-moffitt/assets-bundler/use-jinja2-not-sed
Merge into: lp://staging/assets-bundler
Diff against target: 56 lines (+10/-31)
2 files modified
Makefile (+10/-16)
update-bundles-yaml.sh (+0/-15)
To merge this branch: bzr merge lp://staging/~nick-moffitt/assets-bundler/use-jinja2-not-sed
Reviewer Review Type Date Requested Status
Webteam Backend Pending
Review via email: mp+238278@code.staging.launchpad.net

Description of the change

This change is untested as of now, but it relies on a jinja2 one-liner I've used in many places in the past. The basic trick is that it uses a template snarfed from stdin and populates it with environment variables. This approach isn't always the most robust, but it seems preferrable to a special-purpose script full of sed commands that aim to emulate jinja2's functionality.

The branch removes this script, which I hope will ease the maintenance burden. If the technique is not suitable here for some reason, I hope you will consider it in other situations where you need a quick template.

To post a comment you must log in.

Unmerged revisions

32. By Nick Moffitt

Try actually using jinja2 templates instead of sed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: