Merge lp://staging/~nick-dedekind/unity/multi-instance-icon-loader into lp://staging/unity
Status: | Work in progress |
---|---|
Proposed branch: | lp://staging/~nick-dedekind/unity/multi-instance-icon-loader |
Merge into: | lp://staging/unity |
Diff against target: |
2350 lines (+1138/-850) 10 files modified
dash/ResultRendererTile.cpp (+2/-2) dash/StandaloneDash.cpp (+3/-4) unity-shared/CMakeLists.txt (+1/-0) unity-shared/CoverArt.cpp (+14/-9) unity-shared/CoverArt.h (+4/-2) unity-shared/IconLoader.cpp (+112/-828) unity-shared/IconLoader.h (+16/-5) unity-shared/IconLoaderImpl.h (+119/-0) unity-shared/IconLoaderTask.cpp (+756/-0) unity-shared/IconLoaderTask.h (+111/-0) |
To merge this branch: | bzr merge lp://staging/~nick-dedekind/unity/multi-instance-icon-loader |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Michal Hruby (community) | Needs Fixing | ||
Nick Dedekind (community) | Needs Fixing | ||
Review via email: mp+129125@code.staging.launchpad.net |
Commit message
Added multi-instance Icon Loaders with management.
Description of the change
Added multi-instance Icon Loaders with management.
Icon loaders can be created as requested and deleted when the last reference is removed. This allows better control of internal caching in areas such as dash previews.
All icon loading now asynchronous.
Refactored IconLoaderTask into class.
Refactored IconLoaderTask to remove "shadow tasks" (now adds a slot to existing tasks).
Added task thread-safe ref counting for loader instance deletion during IO scheduled job processing.
Unmerged revisions
- 2829. By Nick Dedekind
-
Fixed referencing issue.
- 2828. By Nick Dedekind
-
Invoke icon slot on coalesce.
- 2827. By Nick Dedekind
-
Merge with trunk
- 2826. By Nick Dedekind
-
IconLoader code refactor.
- 2825. By Nick Dedekind
-
Merge with trunk
- 2824. By Nick Dedekind
-
Added multi-instance icon loaders management.
- 2823. By Nick Dedekind
-
Fixed dash standalone seg-fault on close.
Needs unit test.