Unity

Merge lp://staging/~nick-dedekind/unity/lp1045243.preview-fixed-size into lp://staging/unity

  1. lp1045243.preview-fixed-size
  2. Merge into trunk
Proposed by Nick Dedekind
Status: Merged
Approved by: Brandon Schaefer
Approved revision: no longer in the source branch.
Merged at revision: 2667
Proposed branch: lp://staging/~nick-dedekind/unity/lp1045243.preview-fixed-size
Merge into: lp://staging/unity
Diff against target: 172 lines (+22/-41)
4 files modified
dash/previews/PreviewContainer.cpp (+8/-34)
dash/previews/PreviewContainer.h (+0/-2)
unity-shared/PreviewStyle.cpp (+12/-4)
unity-shared/PreviewStyle.h (+2/-1)
To merge this branch: bzr merge lp://staging/~nick-dedekind/unity/lp1045243.preview-fixed-size
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) Approve
jenkins continuous-integration Pending
Review via email: mp+122655@code.staging.launchpad.net

Commit message

Fixed the size of the previews to 770x380 pixels. (LP#1045243)

Description of the change

Fixed the size of the previews to 770x380 pixels. Resizing dash will not alter size. (LP#1045243)

To post a comment you must log in.
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Hmm instead of returning hardcoded values could you make variables at the top of the class?

ie:
const int preview_width = 770;
etc...

Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Also this happens:
http://i.imgur.com/h29v5.jpg

When you:
Start the dash and set it to fullscreen
Right click an icon to open preview
Now take the dash out of fullscreen and open a preview.

review: Needs Fixing
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

The resize issue in that image is fixed by a related bug.
https://bugs.launchpad.net/unity/+bug/1038944

Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

While I do find it a bit redundant having a style class for values, then defining them somewhere other than the accessors, I have complied with the width/height values. :)

Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Yeah, I figure if someone needs to use that value more then once in this class it's now in a varaible :)

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.