Unity API

Merge lp://staging/~nick-dedekind/unity-api/lp1475678.surface-occlude into lp://staging/unity-api

  1. lp1475678.surface-occlude
  2. Merge into trunk
Proposed by Nick Dedekind
Status: Merged
Approved by: Michał Sawicz
Approved revision: 193
Merged at revision: 193
Proposed branch: lp://staging/~nick-dedekind/unity-api/lp1475678.surface-occlude
Merge into: lp://staging/unity-api
Prerequisite: lp://staging/~mterry/unity-api/no-touch-no-lifecycle
Diff against target: 50 lines (+13/-1)
2 files modified
debian/changelog (+5/-1)
include/unity/shell/application/MirSurfaceInterface.h (+8/-0)
To merge this branch: bzr merge lp://staging/~nick-dedekind/unity-api/lp1475678.surface-occlude
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
PS Jenkins bot (community) continuous-integration Approve
Daniel d'Andrada Pending
Review via email: mp+275884@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-10-05.

Commit message

Support server->client visibility change to stop rendering (lp:#1475678)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:190
http://jenkins.qa.ubuntu.com/job/unity-api-ci/347/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-amd64-ci/35
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-armhf-ci/36
        deb: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-armhf-ci/36/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-i386-ci/35
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-wily-amd64-ci/46
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-wily-armhf-ci/46
        deb: http://jenkins.qa.ubuntu.com/job/unity-api-wily-armhf-ci/46/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-wily-i386-ci/46

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-api-ci/347/rebuild

review: Approve (continuous-integration)
Revision history for this message
Daniel d'Andrada (dandrader) wrote : Posted in a previous version of this proposal

In include/unity/shell/application/Mir.h:

"""
+ Q_ENUMS(Visibility)
"""

Looks like a leftover from a previous version.

review: Needs Fixing
Revision history for this message
Nick Dedekind (nick-dedekind) wrote : Posted in a previous version of this proposal

> In include/unity/shell/application/Mir.h:
>
> """
> + Q_ENUMS(Visibility)
> """
>
> Looks like a leftover from a previous version.

Removed.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:191
http://jenkins.qa.ubuntu.com/job/unity-api-ci/349/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-amd64-ci/37
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-armhf-ci/38
        deb: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-armhf-ci/38/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-i386-ci/37
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-wily-amd64-ci/48
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-wily-armhf-ci/48
        deb: http://jenkins.qa.ubuntu.com/job/unity-api-wily-armhf-ci/48/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-wily-i386-ci/48

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-api-ci/349/rebuild

review: Approve (continuous-integration)
Revision history for this message
Daniel d'Andrada (dandrader) wrote : Posted in a previous version of this proposal

Code looks ok.

Will have to bump "set(VERSION 8)" in include/unity/shell/application/CMakeLists.txt before merging. No point in doing so now as that's being changed already by MPs on the queue for landing.

review: Approve
Revision history for this message
Michał Sawicz (saviq) wrote : Posted in a previous version of this proposal

This needs a version bump in application API CMakeLists.txt

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:193
http://jenkins.qa.ubuntu.com/job/unity-api-ci/356/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-amd64-ci/44
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-armhf-ci/45
        deb: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-armhf-ci/45/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-i386-ci/44
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-wily-amd64-ci/55
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-wily-armhf-ci/55
        deb: http://jenkins.qa.ubuntu.com/job/unity-api-wily-armhf-ci/55/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-wily-i386-ci/55

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-api-ci/356/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Approving as per superseded.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: