Merge lp://staging/~nick-dedekind/ubuntu-settings-components/standard-item-preferred-values into lp://staging/~registry/ubuntu-settings-components/trunk
Proposed by
Nick Dedekind
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Andrea Cimitan | ||||
Approved revision: | 88 | ||||
Merged at revision: | 91 | ||||
Proposed branch: | lp://staging/~nick-dedekind/ubuntu-settings-components/standard-item-preferred-values | ||||
Merge into: | lp://staging/~registry/ubuntu-settings-components/trunk | ||||
Diff against target: |
43 lines (+4/-7) 3 files modified
plugins/Ubuntu/Settings/Menus/GroupedMessageMenu.qml (+2/-2) plugins/Ubuntu/Settings/Menus/StandardMenu.qml (+0/-3) plugins/Ubuntu/Settings/Menus/UserSessionMenu.qml (+2/-2) |
||||
To merge this branch: | bzr merge lp://staging/~nick-dedekind/ubuntu-settings-components/standard-item-preferred-values | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrea Cimitan (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email: mp+257871@code.staging.launchpad.net |
Commit message
Don't use preferred values inside Standard item compoonent Loader.
Description of the change
Don't use preferred values inside Standard item compoonent Loader.
* Are there any related MPs required for this MP to build/function as expected? Please list.
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
To post a comment you must log in.
PASSED: Continuous integration, rev:88 jenkins. qa.ubuntu. com/job/ ubuntu- settings- components- ci/111/ jenkins. qa.ubuntu. com/job/ ubuntu- settings- components- qmltests- vivid/30 jenkins. qa.ubuntu. com/job/ ubuntu- settings- components- vivid-amd64- ci/18 jenkins. qa.ubuntu. com/job/ ubuntu- settings- components- vivid-armhf- ci/18 jenkins. qa.ubuntu. com/job/ ubuntu- settings- components- vivid-armhf- ci/18/artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- settings- components- ci/111/ rebuild
http://