Ubuntu Settings Components

Merge lp://staging/~nick-dedekind/ubuntu-settings-components/icon-aspect-ratio-crop into lp://staging/~registry/ubuntu-settings-components/trunk

  1. icon-aspect-ratio-crop
  2. Merge into trunk
Proposed by Nick Dedekind
Status: Merged
Approved by: Nick Dedekind
Approved revision: 91
Merged at revision: 97
Proposed branch: lp://staging/~nick-dedekind/ubuntu-settings-components/icon-aspect-ratio-crop
Merge into: lp://staging/~registry/ubuntu-settings-components/trunk
Prerequisite: lp://staging/~dandrader/ubuntu-settings-components/deprecation-warnings
Diff against target: 52 lines (+4/-8)
3 files modified
plugins/Ubuntu/Settings/Components/MessageHeader.qml (+0/-1)
plugins/Ubuntu/Settings/Components/UbuntuShapeForItem.qml (+4/-6)
plugins/Ubuntu/Settings/Menus/TransferMenu.qml (+0/-1)
To merge this branch: bzr merge lp://staging/~nick-dedekind/ubuntu-settings-components/icon-aspect-ratio-crop
Reviewer Review Type Date Requested Status
Albert Astals Cid Pending
Sebastien Bacher Pending
PS Jenkins bot continuous-integration Pending
Review via email: mp+271085@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-07-17.

Commit message

Crop icons to aspect ratio inside UbuntuShapes.

Description of the change

Crop icons to aspect ratio inside UbuntuShapes.

 * Are there any related MPs required for this MP to build/function as expected? Please list.
no

 * Did you perform an exploratory manual test run of your code change and any related functionality?
yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a

 * If you changed the UI, has there been a design review?
yes

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:90
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/116/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-vivid/41
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-vivid-amd64-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-vivid-armhf-ci/23
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-vivid-armhf-ci/23/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/116/rebuild

review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote : Posted in a previous version of this proposal

The change looks good and resolves the issue!

review: Approve
Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal

Top approving following Sebastien's approval

review: Abstain
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

Bumped top approve for re-submit on prerequisite branch

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: