qmenumodel

Merge lp://staging/~nick-dedekind/qmenumodel/unitymenuaction.lp1334203 into lp://staging/qmenumodel

  1. unitymenuaction.lp1334203
  2. Merge into trunk
Proposed by Nick Dedekind
Status: Merged
Approved by: Nick Dedekind
Approved revision: 108
Merged at revision: 107
Proposed branch: lp://staging/~nick-dedekind/qmenumodel/unitymenuaction.lp1334203
Merge into: lp://staging/qmenumodel
Diff against target: 177 lines (+77/-7)
4 files modified
libqmenumodel/src/unitymenuaction.cpp (+3/-7)
libqmenumodel/src/unitymenumodel.cpp (+11/-0)
tests/client/CMakeLists.txt (+1/-0)
tests/client/unitymenuactiontest.cpp (+62/-0)
To merge this branch: bzr merge lp://staging/~nick-dedekind/qmenumodel/unitymenuaction.lp1334203
Reviewer Review Type Date Requested Status
Andrea Cimitan (community) Approve
Lars Karlitski (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+225063@code.staging.launchpad.net

Commit message

Unset the UnityMenuActions::model when destroying UnityMenuModel

Description of the change

Unset the UnityMenuActions::model when destroying UnityMenuModel

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:106
http://jenkins.qa.ubuntu.com/job/qmenumodel-ci/49/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qmenumodel-utopic-amd64-ci/2/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qmenumodel-utopic-armhf-ci/2
        deb: http://jenkins.qa.ubuntu.com/job/qmenumodel-utopic-armhf-ci/2/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qmenumodel-ci/49/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:107
http://jenkins.qa.ubuntu.com/job/qmenumodel-ci/50/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qmenumodel-utopic-amd64-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qmenumodel-utopic-armhf-ci/3
        deb: http://jenkins.qa.ubuntu.com/job/qmenumodel-utopic-armhf-ci/3/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qmenumodel-ci/50/rebuild

review: Approve (continuous-integration)
Revision history for this message
Lars Karlitski (larsu) wrote :

Looks good to me, thanks.

review: Approve
Revision history for this message
Andrea Cimitan (cimi) wrote :

Fixes for me, thx

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches