Merge lp://staging/~nick-dedekind/qmenumodel/qdbusactiongroup-variant-conversion into lp://staging/qmenumodel
Proposed by
Nick Dedekind
Status: | Needs review |
---|---|
Proposed branch: | lp://staging/~nick-dedekind/qmenumodel/qdbusactiongroup-variant-conversion |
Merge into: | lp://staging/qmenumodel |
Diff against target: |
298 lines (+167/-13) 7 files modified
libqmenumodel/src/qdbusactiongroup.cpp (+29/-2) libqmenumodel/src/qstateaction.cpp (+2/-4) tests/client/actiongrouptest.cpp (+96/-0) tests/client/script_actiongrouptest.py (+2/-2) tests/script/dbusmenuscript.cpp (+16/-0) tests/script/dbusmenuscript.h (+1/-0) tests/script/menuscript.py (+21/-5) |
To merge this branch: | bzr merge lp://staging/~nick-dedekind/qmenumodel/qdbusactiongroup-variant-conversion |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Lars Karlitski | Pending | ||
Review via email: mp+211908@code.staging.launchpad.net |
Commit message
Action updateState/
Description of the change
Action updateState/
Added tests for implicit type conversion.
To post a comment you must log in.
Unmerged revisions
- 104. By Nick Dedekind
-
Action updateState/
activate uses parameter types to determine corect variant conversion
PASSED: Continuous integration, rev:104 jenkins. qa.ubuntu. com/job/ qmenumodel- ci/46/ jenkins. qa.ubuntu. com/job/ qmenumodel- trusty- amd64-ci/ 8 jenkins. qa.ubuntu. com/job/ qmenumodel- trusty- armhf-ci/ 8 jenkins. qa.ubuntu. com/job/ qmenumodel- trusty- armhf-ci/ 8/artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/qmenumodel- ci/46/rebuild
http://