Merge lp://staging/~nick-craig-wood/goamz/list-buckets2 into lp://staging/goamz

Proposed by Nick Craig-Wood
Status: Needs review
Proposed branch: lp://staging/~nick-craig-wood/goamz/list-buckets2
Merge into: lp://staging/goamz
Diff against target: 164 lines (+103/-13)
3 files modified
s3/responses_test.go (+19/-0)
s3/s3.go (+55/-13)
s3/s3_test.go (+29/-0)
To merge this branch: bzr merge lp://staging/~nick-craig-wood/goamz/list-buckets2
Reviewer Review Type Date Requested Status
goamz maintainers Pending
Review via email: mp+171786@code.staging.launchpad.net

Description of the change

Implement S3.List to list all Buckets

This allows the user to discover all S3 buckets that they have

https://codereview.appspot.com/10684043/

To post a comment you must log in.
Revision history for this message
Nick Craig-Wood (nick-craig-wood) wrote :

See https://code.launchpad.net/~nick-craig-wood/goamz/list-buckets/+merge/146925 for old code review.

I've messed up that branch somehow so here is a new one

39. By Nick Craig-Wood

s3: ListBuckets: Fix signpath which was causing authentication errors

Unmerged revisions

39. By Nick Craig-Wood

s3: ListBuckets: Fix signpath which was causing authentication errors

38. By Nick Craig-Wood

Implement S3.List to list all Buckets

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches