Sound Juicer

Merge lp://staging/~nfmccrina/sound-juicer/space_strip into lp://staging/sound-juicer

  1. space_strip
  2. Merge into main
Proposed by Nathan McCrina
Status: Needs review
Proposed branch: lp://staging/~nfmccrina/sound-juicer/space_strip
Merge into: lp://staging/sound-juicer
Diff against target: None lines
To merge this branch: bzr merge lp://staging/~nfmccrina/sound-juicer/space_strip
To post a comment you must log in.
Revision history for this message
Nathan McCrina (nfmccrina) wrote :

Hi there!
I had noticed that the "strip special characters" option failed to produce a file name completely devoid of special characters. For example, "/Help!/Disc 1 - 7 - Ticket to Ride.flac" became "/Help_/Disc 1 - 7_-_Ticket_to_Ride.flac", leaving spaces still. This messed up some scripts I was running, making the `ls` command screw up or something. Anyway, I edited a line or two so that all spaces are kaput. It seems to work perfectly, I compiled the whole thing and ripped a disc and everything turned out all right. I'm not sure if I'm going about this correctly, not only am I new to this project but I'm kind of a n00b when it comes to Bazaar and Launchpad as well. So I apologize if I'm just barging in rudely. Hopefully this is an improvement, though!
Cheers,
Nathan McCrina
<email address hidden>

Reply

Unmerged revisions

2193. By Nathan McCrina

Took out a stupid 'B' I had put in for debugging and forgotten about

2192. By Nathan McCrina

Altered (fixed?) so that spaces in disc number get replaced by underscores in the sanitize_path function

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/sj-extracting.c'
2--- src/sj-extracting.c 2009-02-10 21:57:56 +0000
3+++ src/sj-extracting.c 2009-07-17 04:41:09 +0000
4@@ -1054,7 +1054,8 @@
5 case 'n':
6 /* Disc and track number */
7 if (track->album->disc_number > 0) {
8- string = g_strdup_printf ("Disc %d - %d", track->album->disc_number, track->number);
9+ /* Changed so that the spaces in the disc-number section of the filename are replaced with underscores. Nathan McCrina <nfmccrina@gmail.com> */
10+ string = sanitize_path(g_strdup_printf("Disc %d - %d", track->album->disc_number, track->number), filesystem_type);
11 } else {
12 string = g_strdup_printf ("%d", track->number);
13 }

Subscribers

No one subscribed via source and target branches